allow building on JDK 15 #1929
Merged
allow building on JDK 15 #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catap
reviewed
Dec 2, 2020
| @@ -1,8 +1,5 @@ | |||
| -server | |||
| -Xms512M | |||
| -Xmx4000M | |||
There was a problem hiding this comment.
this is 1929, you meant 1904 and...?
There was a problem hiding this comment.
oh, I see it now, #1928
There was a problem hiding this comment.
@SethTisue and this is that only I know!
Merged
smarter
reviewed
Dec 7, 2020
| @@ -1383,7 +1383,7 @@ private[scalatest] object RefSpec { | |||
| else | |||
| value | |||
|
|
|||
| val bytes = Codec.toUTF8(toHash.toArray) | |||
| val bytes = Codec.toUTF8(toHash) | |||
There was a problem hiding this comment.
This change is already part of #1923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this came up in the Scala community build, where we build on 11 and 15 as well as 8