Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear the Function0 reference of Need #422

Merged
merged 2 commits into from Jul 24, 2013

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Jul 9, 2013

inspired by sbt SafeLazy

old version xuwei-k@e52825eb3d1dbcd

@S11001001
Copy link
Member

Is lazy val guaranteed by SLS to be implemented using an exclusive lock rather than compare-and-swap?

@larsrh
Copy link
Contributor

larsrh commented Jul 14, 2013

I have no opinion on that matter, because I'm not knowledgeable enough about lazy val semantics.

@larsrh
Copy link
Contributor

larsrh commented Jul 22, 2013

The test is quite dodgy, but I guess that's okay if you want to test that sort of thing :-) 👍

xuwei-k added a commit that referenced this pull request Jul 24, 2013
clear the Function0 reference of Need
@xuwei-k xuwei-k merged commit dafa59f into scalaz:scalaz-seven Jul 24, 2013
@xuwei-k xuwei-k deleted the request/need branch July 24, 2013 03:46
@larsrh
Copy link
Contributor

larsrh commented Jul 25, 2013

Cannot be backported:

[error]  * synthetic method value0$1(scala.Function0,scala.runtime.ObjectRef,scala.runtime.VolatileIntRef)java.lang.Object in object scalaz.Need does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingMethodProblem]("scalaz.Need.value0$1")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants