Fix deprecation warnings #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dry-types 0.12.0 deprecated Types::Array#member and introduced a replacement Types::Array#of in the same release [1]. Sigh. This means that for dry-types <0.12, you must use Types::Array#member because #of doesn't exist, but for dry-types >=0.12, you must use Types::Array#of because #member emits a noisy deprecation warning. This commit is a quick fix: it changes the gemspec to require >= 0.12, and uses #of. [1]: https://github.com/dry-rb/dry-types/blob/master/CHANGELOG.md#v0120-2017-09-15
|
BTW I haven't actually tested this - I couldn't see any development or hacking docs to indicate how to run the tests |
|
I don't see anything in my PR that caused the build to fail 😕 the rubocop issues were there already |
|
I've also just discovered that these deprecation warnings break |
|
Remove the Ruby 2.1 test from |
|
@randomvariable if we remove it from |
|
Yup, and the README.md. We'll bump to 1.0.0 after this I think. |
I used 2.3.1 because I happen to have it installed locally :)
|
rubocop fails massively for me locally, i feel like i'm missing some definitions somewhere. pushed an update as discussed anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dry-types 0.12.0 deprecated Types::Array#member and introduced a
replacement Types::Array#of in the same release. Sigh.
This means that for dry-types <0.12, you must use Types::Array#member
because #of doesn't exist, but for dry-types >=0.12, you must use
Types::Array#of because #member emits a noisy deprecation warning.
This commit is a quick fix: it changes the gemspec to require >= 0.12,
and uses #of.