Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: json output for empty array #1034

Merged
merged 6 commits into from
May 28, 2020
Merged

fix: json output for empty array #1034

merged 6 commits into from
May 28, 2020

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@remyleone remyleone linked an issue May 28, 2020 that may be closed by this pull request
When a command returns an empty array in JSON it should not be null #869
Closed
@remyleone
Copy link
Member Author

We need to add a test with an empty list of resource and an output in json

jerome-quere
jerome-quere approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit c149c79 into scaleway:v2 May 28, 2020
@remyleone remyleone deleted the json_printer branch May 28, 2020 17:29
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@Monitob
fix(lb): ip cassette (scaleway#1034)
b084aa1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a command returns an empty array in JSON it should not be null
2 participants
@remyleone @jerome-quere