Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): add human marshalling for user-data #1300

Merged
merged 2 commits into from
Jul 29, 2020
Merged

feat(instance): add human marshalling for user-data #1300

merged 2 commits into from
Jul 29, 2020

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@remyleone remyleone linked an issue Jul 28, 2020 that may be closed by this pull request
improve human marshall for instance user data #1231
Closed
kindermoumoute
kindermoumoute approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 2d4a8a2 into scaleway:master Jul 29, 2020
@remyleone remyleone deleted the human_marshall branch July 29, 2020 12:12
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve human marshall for instance user data
2 participants
@remyleone @kindermoumoute