Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use right implementation for instanceID #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use right implementation for instanceID #45

wants to merge 1 commit into from

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Nov 25, 2020 •
edited
Loading

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

Let's wait the answer to kubernetes/kubernetes#96871 first

@Sh4d1
fix: use right implementation for instanceID
576222b 
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
jtherin
jtherin approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@jtherin jtherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtherin jtherin jtherin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sh4d1 @jtherin