Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance_image) : add resource for instance image #1331

Merged
merged 26 commits into from
Jul 8, 2022

Conversation

Mia-Cross
Copy link
Contributor

In response to this issue, we will be adding a new resource to the Terraform provider : instance images.

@Mia-Cross Mia-Cross force-pushed the instance_image_resource branch 2 times, most recently from bc553ff to c3a4b97 Compare June 17, 2022 13:54
@Mia-Cross
Copy link
Contributor Author

Mia-Cross commented Jun 17, 2022

Supported attributes for instance images are :

  • Zone
  • Name
  • Root volume
  • Architecture
  • Default bootscript (keep in update ?)
  • Extra_volumes (create + read ok, only update left to implement)
  • Project
  • Tags
  • Public
  • Creation date
  • Modification date
  • From server
  • Organization
  • State

Images can be made from a snapshot of :

  • a server
  • a block storage volume
  • a server with a block storage volume (depends on extra_volumes)
  • a server with a local storage volume (depends on extra_volumes)
  • a combination of block storage volumes
  • a server with combination of both block and local storage (depends on extra_volumes)

@Mia-Cross
Copy link
Contributor Author

@remyleone can you checkout the test "TestAccScalewayInstanceImage_SeveralVolumes" ? The weird behavior happens at the 5th and 6th checks concerning additional_volumes. It says "pass" although the part where I set the additional_volumes in the CREATE function is commented and I don't even mention them in the READ function so there's no way they are set.
I tried the debugger but it doesn't seem to step into any function so I don't understand what's happening...

@Mia-Cross Mia-Cross linked an issue Jun 24, 2022 that may be closed by this pull request
scaleway/resource_instance_image_test.go Outdated Show resolved Hide resolved
scaleway/resource_instance_image.go Show resolved Hide resolved
scaleway/resource_instance_image.go Outdated Show resolved Hide resolved
scaleway/resource_instance_image.go Outdated Show resolved Hide resolved
scaleway/resource_instance_image.go Outdated Show resolved Hide resolved
@Mia-Cross Mia-Cross marked this pull request as ready for review July 7, 2022 14:05
go.sum Show resolved Hide resolved
scaleway/resource_instance_image.go Outdated Show resolved Hide resolved
scaleway/resource_instance_image.go Show resolved Hide resolved
@remyleone remyleone merged commit bd1d718 into scaleway:master Jul 8, 2022
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
@Mia-Cross Mia-Cross deleted the instance_image_resource branch January 27, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a resource for instance image
4 participants