Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(function): add function triggers #1912

Merged
merged 7 commits into from
May 29, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Apr 25, 2023

No description provided.

@Codelax Codelax added enhancement function Serverless function issues, bugs and feature requests labels Apr 25, 2023
@Codelax Codelax self-assigned this Apr 25, 2023
@remyleone remyleone added the priority:highest Bugs filled by customers, security issues label May 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #1912 (d52f699) into master (c97546b) will decrease coverage by 0.11%.
The diff coverage is 62.10%.

@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
- Coverage   74.01%   73.90%   -0.11%     
==========================================
  Files         177      179       +2     
  Lines       27578    27865     +287     
==========================================
+ Hits        20412    20595     +183     
- Misses       5431     5513      +82     
- Partials     1735     1757      +22     
Impacted Files Coverage Δ
scaleway/resource_function.go 67.86% <0.00%> (-0.77%) ⬇️
scaleway/helpers_function_triggers.go 59.09% <59.09%> (ø)
scaleway/resource_function_trigger.go 60.89% <60.89%> (ø)
scaleway/helpers_function.go 73.74% <100.00%> (+2.05%) ⬆️
scaleway/provider.go 79.27% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

@Codelax Codelax marked this pull request as ready for review May 24, 2023 12:52
@remyleone remyleone added this pull request to the merge queue May 29, 2023
Merged via the queue into scaleway:master with commit a5bb81a May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement function Serverless function issues, bugs and feature requests priority:highest Bugs filled by customers, security issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants