Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lb): add lb acl #1948

Merged
merged 9 commits into from
May 29, 2023
Merged

feat(lb): add lb acl #1948

merged 9 commits into from
May 29, 2023

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented May 22, 2023

No description provided.

@yfodil yfodil added enhancement load-balancer Load-balancer issues, bugs and feature requests labels May 22, 2023
@yfodil yfodil self-assigned this May 22, 2023
@yfodil yfodil marked this pull request as ready for review May 26, 2023 13:03
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023 •
edited

Codecov Report

Merging #1948 (ed96331) into master (f7c65c0) will increase coverage by 0.14%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
+ Coverage   73.90%   74.05%   +0.14%     
==========================================
  Files         179      180       +1     
  Lines       27861    28120     +259     
==========================================
+ Hits        20592    20824     +232     
- Misses       5515     5534      +19     
- Partials     1754     1762       +8
Impacted Files Coverage Δ
scaleway/helpers_lb.go 84.85% <66.66%> (-0.51%) ⬇️
scaleway/resource_lb_acl.go 87.23% <87.23%> (ø)
scaleway/resource_lb_frontend.go 80.92% <93.02%> (+2.15%) ⬆️
scaleway/provider.go 79.34% <100.00%> (+0.06%) ⬆️

Monitob
Monitob suggested changes May 29, 2023
View reviewed changes
docs/resources/lb_acl.md Outdated Show resolved Hide resolved
scaleway/resource_lb_frontend.go Show resolved Hide resolved
@yfodil yfodil added this pull request to the merge queue May 29, 2023
Merged via the queue into scaleway:master with commit af89512 May 29, 2023
@yfodil yfodil deleted the add_lb_acl_resource branch May 29, 2023 13:32
@yfodil yfodil linked an issue May 30, 2023 that may be closed by this pull request
Resource LB frontend ACL #1945
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone left review comments

@Monitob Monitob Monitob approved these changes

Assignees

@yfodil yfodil

Labels
enhancement load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource LB frontend ACL
4 participants
@yfodil @codecov-commenter @remyleone @Monitob