Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): get raw config for key #2419

Merged
merged 3 commits into from Mar 21, 2024

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Feb 23, 2024

Closes #2418

Needs #2461 first

@Mia-Cross Mia-Cross self-assigned this Feb 23, 2024
@Mia-Cross Mia-Cross force-pushed the chore_get_raw_config_for_key branch from 3dd588c to 83d5a89 Compare March 5, 2024 15:52
@Mia-Cross Mia-Cross force-pushed the chore_get_raw_config_for_key branch from 3b828f1 to 21fb3b4 Compare March 14, 2024 15:49
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 73.58491% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 73.13%. Comparing base (ba2827f) to head (4abdd53).

Files Patch % Lines
scaleway/helpers.go 70.21% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2419      +/-   ##
==========================================
+ Coverage   73.08%   73.13%   +0.05%     
==========================================
  Files         242      242              
  Lines       35357    35396      +39     
==========================================
+ Hits        25840    25887      +47     
+ Misses       7293     7286       -7     
+ Partials     2224     2223       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross force-pushed the chore_get_raw_config_for_key branch from 1486ccf to fcf3d4b Compare March 21, 2024 15:02
@Mia-Cross Mia-Cross marked this pull request as ready for review March 21, 2024 16:34
@remyleone remyleone added this pull request to the merge queue Mar 21, 2024
Merged via the queue into scaleway:master with commit 635420c Mar 21, 2024
34 checks passed
@Mia-Cross Mia-Cross deleted the chore_get_raw_config_for_key branch March 21, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a function to read the user's raw config
4 participants