fix(rdb): allow updates from bssd to lssd if new node type has enough space #2461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a case that did not occur in the tests but there was a bug when changing the volume type from
bssd
tolssd
as thevolume_size_in_gb
attribute goes from the given value to 0 (the volume size depends on the node type). And since we carry out the upgrades starting from the volume and ending with the node type, that resulted in the API rejecting the update of thevolume_type
because thenode_type
should be updated first.To fix the issue, this PR adds the comparing of the actual and the wanted storage capacities to see if the node_type has to be updated first.