Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instance): handle root volume with no size as default #681

Merged
merged 7 commits into from
Nov 30, 2020
Merged

fix(instance): handle root volume with no size as default #681

merged 7 commits into from
Nov 30, 2020

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone self-assigned this Nov 4, 2020
@remyleone remyleone marked this pull request as draft November 4, 2020 17:28
@remyleone remyleone linked an issue Nov 4, 2020 that may be closed by this pull request
Can't spawn dev1-l/xl with additional volumes #519
Closed
jerome-quere
jerome-quere reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have a look at the create server in the CLI IIRC we have the same kind of fix

@remyleone remyleone marked this pull request as ready for review November 25, 2020 17:04
jerome-quere
jerome-quere suggested changes Nov 26, 2020
View reviewed changes
scaleway/helpers_instance.go Show resolved Hide resolved
scaleway/resource_instance_server.go Outdated Show resolved Hide resolved
scaleway/resource_instance_server_test.go Outdated Show resolved Hide resolved
@remyleone remyleone merged commit 0efc359 into scaleway:master Nov 30, 2020
@remyleone remyleone deleted the size_not_specified branch November 30, 2020 14:03
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees

@remyleone remyleone

Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't spawn dev1-l/xl with additional volumes
2 participants
@remyleone @jerome-quere