Skip to content

Commit

Permalink
fix(Popup): new prop and improve initial positioning of the popup (#3730
Browse files Browse the repository at this point in the history
)

* fix(Popup): new prop and improve initial positioning of the popup

* fix: remove the blink
  • Loading branch information
matthprost committed Apr 30, 2024
1 parent fe928a2 commit 0f133ea
Show file tree
Hide file tree
Showing 11 changed files with 718 additions and 396 deletions.
7 changes: 7 additions & 0 deletions .changeset/strange-years-fly.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@ultraviolet/ui": patch
---

- Fix `<Popup />` component to set initial position to 0 avoiding scroll on top when appearing and if an input has `autoFocus` inside
- New prop `dynamicDomRendering` to define if the popup will be rendered dynamically in the DOM or if it should be rendered at first render. Default is `true` to keep the current retro compatibility.
- Fix `<SelectInputV2 />` to remove timeout on search bar focus
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ exports[`SelectInputField should display right value on grouped options 1`] = `
fill: none;
}
.cache-bmgp9d {
.cache-1opjlsj {
background: #151a2d;
color: #ffffff;
border-radius: 4px;
Expand All @@ -282,6 +282,7 @@ exports[`SelectInputField should display right value on grouped options 1`] = `
inset: 0 auto auto 0;
top: 0;
left: 0;
opacity: 0;
z-index: 1;
-webkit-transform: translate3d(0px, 12px, 0);
-moz-transform: translate3d(0px, 12px, 0);
Expand All @@ -294,7 +295,7 @@ exports[`SelectInputField should display right value on grouped options 1`] = `
padding: 0;
}
.cache-bmgp9d[data-has-arrow='true']::after {
.cache-1opjlsj[data-has-arrow='true']::after {
content: ' ';
position: absolute;
top: -13px;
Expand All @@ -310,6 +311,10 @@ exports[`SelectInputField should display right value on grouped options 1`] = `
pointer-events: none;
}
.cache-1opjlsj[data-visible-in-dom='false'] {
display: none;
}
.cache-77g8v1 {
display: -webkit-box;
display: -webkit-flex;
Expand Down Expand Up @@ -615,10 +620,11 @@ exports[`SelectInputField should display right value on grouped options 1`] = `
</div>
</div>
<div
class="eeucz6c8 cache-bmgp9d e4h1g861"
class="eeucz6c8 cache-1opjlsj e4h1g861"
data-has-arrow="false"
id=":rc:"
role="dialog"
style="opacity: 1;"
>
<div
class="cache-77g8v1 ehpbis70"
Expand Down

0 comments on commit 0f133ea

Please sign in to comment.