fix(Popup): new prop and improve initial positioning of the popup #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e26468a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3730 +/- ##
==========================================
- Coverage 89.61% 89.58% -0.04%
==========================================
Files 190 190
Lines 4189 4196 +7
Branches 626 629 +3
==========================================
+ Hits 3754 3759 +5
- Misses 320 321 +1
- Partials 115 116 +1
Continue to review full report in Codecov by Sentry.
|
lisalupi
approved these changes
Apr 30, 2024
DorianMaliszewski
approved these changes
Apr 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
<Popup />component to set initial position to 0 avoiding scroll on top when appearing and if an input hasautoFocusinsidedynamicDomRenderingto define if the popup will be rendered dynamically in the DOM or if it should be rendered at first render. Default istrueto keep the current retro compatibility.<SelectInputV2 />to remove timeout on search bar focus