refactor: improve illustrations #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0609d70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lisalupi
changed the title
lisalupi
force-pushed
the
research/improve-illustrations
branch
from
f1c7326
to
a576062
Compare
lisalupi
force-pushed
the
research/improve-illustrations
branch
from
20acacc
to
6ddd0d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3845 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 185 185
Lines 5921 5921
Branches 2632 2631 -1
=======================================
Hits 5536 5536
Misses 385 385 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philibea
reviewed
Jun 12, 2024
philibea
reviewed
Jun 12, 2024
philibea
reviewed
Jun 12, 2024
matthprost
requested changes
Jun 12, 2024
matthprost
requested changes
Jun 12, 2024
matthprost
approved these changes
Jun 13, 2024
scaleway-bot
approved these changes
Jun 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Illustrations are now imported from an S3 bucket.
The following changes were made:
Update import of every illustration
New command to upload illustrations to a S3 bucket when doing a pull request