Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the service provider deferred #34

Merged
merged 1 commit into from
Mar 12, 2015
Merged

Make the service provider deferred #34

merged 1 commit into from
Mar 12, 2015

Conversation

Gawdl3y
Copy link
Contributor

@Gawdl3y Gawdl3y commented Sep 28, 2014

This will avoid loading the service provider (and connecting to the Sphinx server) until the provider is actually used. Since most applications will only use the provider on a fraction of pages, it should result in an overall performance increase.
See the deferred providers info in the Laravel documentation.

@dcelasun
Copy link

@dvigueras Can you please merge this? Loading this library on every request is wasteful, so a deferred approach would be better.

dvigueras pushed a commit that referenced this pull request Mar 12, 2015
Make the service provider deferred
@dvigueras dvigueras merged commit d05ad04 into scaliaes:master Mar 12, 2015
@dcelasun
Copy link

@dvigueras Thanks! Can you also tag a new minor relase?

@alexvikman
Copy link

This change seems to have broken the package namespacing of the config when loading it in the construct of SphinxSearch.php.

This works fine.

$host = \Config::get('packages/scalia/sphinxsearch/config.host');

This just returns an empty array now.

$host = \Config::get('sphinxsearch::host');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants