Update scrapyapperyio.py #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encode response.body with utf-8, otherwise the json.loads function will fail
urlencode function doesn't exist in urllib, but in urlib.parse in python3. Now it works well for both python2 and python3.
|
Thanks @dragonabyss! Will have a look at it in the next 2 days! |
lookfwd
reviewed
May 26, 2017
scrapyapperyio.py
Outdated
| @@ -55,7 +58,7 @@ def process_item(self, item, spider): | |||
| def extract_session(response): | |||
| if response.status != 200: | |||
| raise RuntimeError("Unable to login: %s" % response.body) | |||
| self._session = json.loads(response.body)['sessionToken'] | |||
| self._session = json.loads(str(response.body,encoding='utf-8'))['sessionToken'] | |||
There was a problem hiding this comment.
It all looks perfect - I would add a space after the ',' for pep8'ish (although the rest of the file isn't right now)
There was a problem hiding this comment.
Yes，and I have added a space after comma.
add a space after comma
|
Thanks a lot! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode response.body with utf-8, otherwise the json.loads function will fail.