Ft/utapi auth #153
Ft/utapi auth #153
Conversation
LaurenSpiegel
force-pushed
the
ft/utapiAuth
branch
2 times, most recently
from
9b61383
to
3f2856e
Compare
|
👍 |
1 similar comment
|
👍 |
LaurenSpiegel
force-pushed
the
ft/utapiAuth
branch
from
ba24687
to
3f2856e
Compare
|
LGTM 👍 |
|
👍 |
LaurenSpiegel
force-pushed
the
ft/utapiAuth
branch
from
fd1c732
to
6b96388
Compare
| @@ -35,27 +35,44 @@ function _findAction(service, method) { | |||
| if (service === 's3') { | |||
| return _actionMap[method]; | |||
| } | |||
| if (service === 'utapi') { | |||
There was a problem hiding this comment.
else if would make more sense. Or a switch statement.
There was a problem hiding this comment.
This will be expanding at some point so I want to be clear which service is being used. When we get beyond 3 items, we can organize with an object or map structure.
| } | ||
| return 'arn:aws:s3:::'; | ||
| } | ||
| if (service === 'utapi') { |
| // arn:scality:utapi:::resourcetype/resource | ||
| // (possible resource types are buckets, accounts or users) | ||
| if (specificResource) { | ||
| return `arn:scality:utapi:::${generalResource}/${specificResource}`; |
There was a problem hiding this comment.
This is plain duplication if we look a few lines above. Can we get rid of that?
There was a problem hiding this comment.
I want to keep the different services separate at least for now.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "arsenal", | |||
| "version": "1.1.0", | |||
| "version": "1.1.0-utapi", | |||
There was a problem hiding this comment.
it's in a drop me commit to make sure integration was picking up the right version.
| @@ -1112,6 +1112,24 @@ describe('policyEvaluator', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('policyEvaluator for utapi', () => { | |||
There was a problem hiding this comment.
the wildcards, variables, conditions and operators are not different for utapi so no need to replicate the prior tests.
LaurenSpiegel
force-pushed
the
ft/utapiAuth
branch
2 times, most recently
from
bf28f35
to
eafbdcd
Compare
ghost
mentioned this pull request
These changes are needed to enable authorization checks for utapi requests.