FIX: Handle empty signed headers #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenSpiegel
force-pushed
the
fix/v4Headers
branch
2 times, most recently
from
5aa9170
to
2afb16f
Compare
|
@ironman-machine please |
|
Hello @LaurenSpiegel, Starting end to end procedure using the following payload: Please follow http://ci.ironmann.io/gh/scality/Integration/4083 for circle status. |
nicolas2bert
approved these changes
Sep 22, 2016
LaurenSpiegel
force-pushed
the
fix/v4Headers
branch
from
2afb16f
to
4321e20
Compare
rachedbenmustapha
approved these changes
Sep 22, 2016
|
Shouldn't this be also backported in |
|
This issue was not introduced into rel/1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since an empty string is interpreted as false, just checking whether the header value existed was resulting in missing a signed header that had an empty string as its value.
Fixes #163