tentative fix for the maxKeys==0 bug + unit test #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennettbuchanan
approved these changes
Jun 6, 2017
ThibaultRiviere
approved these changes
Jul 23, 2017
ghost
changed the base branch from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #250
This fix seems to be ok for bucketfile backend, but is likely to introduce regressions for bucketclient/MetaData because
maxKeys==0seems to have a special treatment (could be a special case to allow 10000 keys in listing for multi-part?)Anyway, let's start here and see what we can do to fix the big picture from there.