Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTFE-194: add Pod TermintationGracePeriod #67

Merged
merged 3 commits into from
May 17, 2023
Merged

PTFE-194: add Pod TermintationGracePeriod #67

merged 3 commits into from
May 17, 2023

Conversation

Abubakarr99
Copy link
Contributor

No description provided.

@Abubakarr99 Abubakarr99 requested a review from a team May 16, 2023 08:56
@bert-e
Copy link
Contributor

bert-e commented May 16, 2023

Hello abubakarr99,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 16, 2023

Incorrect Jira project

The Jira issue PTFE-194 specified in the source
branch name, does not belong to project EVE, PIPDEP, RELENG.

tcarmet
tcarmet approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting some changes. They are optional

charts/artifacts/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/artifacts/values.yaml Outdated Show resolved Hide resolved
Abubakarr99 and others added 2 commits May 17, 2023 09:45
@Abubakarr99 @tcarmet
PTFE-194: set terminationgraceperiod by default
3ef98de 
Co-authored-by: Thomas Carmet <thomas.carmet@scality.com>
@Abubakarr99 @tcarmet
PTFE-194: set terminationgraceperiod at 300s
f7503f1 
Co-authored-by: Thomas Carmet <thomas.carmet@scality.com>
@bert-e
Copy link
Contributor

bert-e commented May 17, 2023

Queue out of order

The changeset has received all authorizations to enter the merge queue,
however the merge queue is currently in an incoherent state. In order
to protect this pull request, I have not added the changeset to the
queue.

Look into https://devdocs.scality.net/support/faq/#bert-e for guidance about
what to do next to unlock the situation, or ask for help on the #ci-support
Slack channel.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 17, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

@scality scality deleted a comment from bert-e May 17, 2023
@Abubakarr99
Copy link
Contributor Author

/approve

@Abubakarr99 Abubakarr99 requested a review from tcarmet May 17, 2023 14:37
@tcarmet tcarmet merged commit 8aa2936 into development/4.2 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nootal nootal nootal approved these changes

@tcarmet tcarmet Awaiting requested review from tcarmet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abubakarr99 @bert-e @nootal @tcarmet