Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELENG-6240 add release.yaml for bert-e push into harbor #59

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

robin-hesling
Copy link
Contributor

BERTE-575

@robin-hesling robin-hesling requested a review from a team as a code owner July 6, 2022 12:11
@robin-hesling robin-hesling requested a review from a user July 6, 2022 12:11
@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2022

Hello azu-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@scality scality deleted a comment from bert-e Jul 6, 2022
@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, just take into account those small two suggestion please :)

.github/workflows/release.yaml Show resolved Hide resolved
Comment on lines 16 to 17


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing some empty lines:

Suggested change

required: true

jobs:
release-manager:
Copy link
Contributor

@tcarmet tcarmet Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional:

Suggested change
release-manager:
release:

@robin-hesling
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Jul 8, 2022
@bert-e
Copy link
Contributor

bert-e commented Jul 8, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/3.6

The following branches will NOT be impacted:

  • development/1.0
  • development/2.0
  • development/3.0
  • development/3.1
  • development/3.2
  • development/3.3
  • development/3.4
  • development/3.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 8, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/3.6

The following branches have NOT changed:

  • development/1.0
  • development/2.0
  • development/3.0
  • development/3.1
  • development/3.2
  • development/3.3
  • development/3.4
  • development/3.5

Please check the status of the associated issue BERTE-575.

Goodbye azu-scality.

@bert-e bert-e merged commit 4438c6a into development/3.6 Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants