Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Volume creation : button add for labels should change from disable to enable status when a label value and key is provided #3303

Closed
JBWatenbergScality opened this issue Apr 20, 2021 · 1 comment · Fixed by #3338
Closed

ui: Volume creation : button add for labels should change from disable to enable status when a label value and key is provided #3303

JBWatenbergScality opened this issue Apr 20, 2021 · 1 comment · Fixed by #3338
Assignees
@ChengYanJin
Labels
topic:ui UI-related issues
Milestone
MetalK8s 2.9.2

Comments

@JBWatenbergScality
Copy link
Contributor

Component:

UI

Why this is needed:

From a ux point of view it is not enough evident that we have to click add button when having entered the label, leading to human error creating the volume without the label despite having filled it in.

image

What should be done:

We should change the status of the button once having provided a label key and value so that the user clearly see the required action.

Test plan:

Unit test
@JBWatenbergScality JBWatenbergScality added the topic:ui UI-related issues label Apr 20, 2021
@ChengYanJin ChengYanJin mentioned this issue Apr 28, 2021
Closed
@ChengYanJin ChengYanJin added this to the Metalk8s 2.9.1 milestone Apr 28, 2021
@ChengYanJin ChengYanJin self-assigned this Apr 29, 2021
ChengYanJin added a commit that referenced this issue Apr 29, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
d6a5daf 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
@ChengYanJin ChengYanJin mentioned this issue Apr 30, 2021
Merged
ChengYanJin added a commit that referenced this issue Apr 30, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
eb39524 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
ChengYanJin added a commit that referenced this issue Apr 30, 2021
@ChengYanJin
ui: Set the button disable when it's not ready
7a961e2 
Refs: #3303
ChengYanJin added a commit that referenced this issue Apr 30, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
f5c9b92 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
ChengYanJin added a commit that referenced this issue Apr 30, 2021
@ChengYanJin
ui: Set the button disable when it's not ready
c86eb71 
Refs: #3303
ChengYanJin added a commit that referenced this issue May 3, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
40f7e96 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
ChengYanJin added a commit that referenced this issue May 3, 2021
@ChengYanJin
ui: Set the button disable when it's not ready
ddfc975 
Refs: #3303
ChengYanJin added a commit that referenced this issue May 4, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
a8e8c5c 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
ChengYanJin added a commit that referenced this issue May 4, 2021
@ChengYanJin
ui: Set the button disable when it's not ready
47934ef 
Refs: #3303
@ChengYanJin
Copy link
Contributor

merged in #3338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChengYanJin ChengYanJin

Labels
topic:ui UI-related issues
Projects
None yet
Milestone
MetalK8s 2.9.2
Development

Successfully merging a pull request may close this issue.

ui: Bugfix several bug fixes around cluster version create volume scality/metalk8s
3 participants
@ChengYanJin @TeddyAndrieux @JBWatenbergScality