Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in display when adding a new disk with long labels #3328

Closed
lavigne958 opened this issue Apr 27, 2021 · 1 comment
Closed

Bug in display when adding a new disk with long labels #3328

lavigne958 opened this issue Apr 27, 2021 · 1 comment
Assignees
@ChengYanJin
Labels
complexity:easy Something that requires less than a day to fix kind:bug Something isn't working severity:minor No impact, or minor impact, on live deployments topic:ui UI-related issues
Milestone
MetalK8s 2.9.2

Comments

@lavigne958
Copy link

Component:

UI

What happened:
I clicked on Volumes => + create volume => added a label that is longer than expected.
The label key is overlapping on the label value which makes it hard to read.

What was expected:
The list of labels is nicely displayed

Steps to reproduce
Add a new volume and add very long label key

Resolution proposal (optional):

image (2)
@lavigne958 lavigne958 added topic:ui UI-related issues complexity:medium Something that requires one or few days to fix severity:minor No impact, or minor impact, on live deployments labels Apr 27, 2021
@ChengYanJin ChengYanJin added kind:bug Something isn't working complexity:easy Something that requires less than a day to fix and removed complexity:medium Something that requires one or few days to fix labels Apr 27, 2021
@ChengYanJin ChengYanJin added this to the Metalk8s 2.9.1 milestone Apr 28, 2021
@ChengYanJin ChengYanJin self-assigned this Apr 29, 2021
ChengYanJin added a commit that referenced this issue Apr 29, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
d6a5daf 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
@ChengYanJin ChengYanJin mentioned this issue Apr 30, 2021
Merged
ChengYanJin added a commit that referenced this issue Apr 30, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
eb39524 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
ChengYanJin added a commit that referenced this issue Apr 30, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
f5c9b92 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
ChengYanJin added a commit that referenced this issue May 3, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
40f7e96 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
ChengYanJin added a commit that referenced this issue May 4, 2021
@ChengYanJin
ui: Fix the bug of around create volume labels field
a8e8c5c 
UX improvement:
When the labelName and labelValue are not empty, we change the color of
the button to indicate clicking on the `Add` button is necessary.

Refs: #3303 #3328
@ChengYanJin
Copy link
Contributor

merged in #3338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChengYanJin ChengYanJin

Labels
complexity:easy Something that requires less than a day to fix kind:bug Something isn't working severity:minor No impact, or minor impact, on live deployments topic:ui UI-related issues
Projects
None yet
Milestone
MetalK8s 2.9.2
Development

No branches or pull requests
3 participants
@lavigne958 @ChengYanJin @TeddyAndrieux