Remove support for kubernetes basic auth #2119

Ebaneck · 2019-12-10T08:29:20Z

Component:

'kubernetes', 'tests'

Context:

See #2072

Summary:

Kubernetes basic auth functionality on MetalK8s has reached end of life.
Tests removed in this PR will henceforth be curated with cypress.

Acceptance criteria:

Closes: #2072

bert-e · 2019-12-10T08:29:22Z

Hello ebaneck,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2019-12-10T08:29:27Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

tests/post/features/salt_api.feature

gdemonet

LGTM, minor nitpick for docs

docs/operation/account_administration.rst

After the introduction of OIDC based authentication, we need to depreciate the use of basic auth in MetalK8s. For this to happen, this PR removes configurations related to basic authentication

After the introduction of OIDC based authentication in Metalk8s, tests that rely on basic authentication will no longer work since basic auth will become depreciated. This commit removes salt-api authentication tests that rely on basic auth

After the depreciation and removal of basic-auth in kubeapiserver, there is no need to continue to have support for basic auth in our salt/kubernetes module.

Ebaneck · 2019-12-11T15:07:49Z

/help

bert-e · 2019-12-11T15:07:53Z

Help page

The following options and commands are available at this time.

Options

name	description	privileged	authored
➡️ create_pull_requests	Allow the creation of integration pull requests.
➡️ bypass_author_approval	Bypass the pull request author's approval	⭐
➡️ bypass_commit_size	Bypass the check on the size of the changeset `TBA`	⭐
➡️ unanimity	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
➡️ bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
➡️ bypass_build_status	Bypass the build and test status	⭐
➡️ approve	Instruct Bert-E that the author has approved the pull request.		✍️
➡️ after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
➡️ wait	Instruct Bert-E not to run until further notice.
➡️ bypass_jira_check	Bypass the Jira issue check	⭐
➡️ no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
➡️ bypass_leader_approval	Bypass the pull request leaders' approval	⭐
➡️ bypass_peer_approval	Bypass the pull request peers' approval	⭐

Commands

name	description	privileged
➡️ reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.
➡️ help	Print Bert-E's manual in the pull request.
➡️ build	Re-start a fresh build `TBA`
➡️ force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
➡️ retry	Re-start a fresh build `TBA`
➡️ status	Print Bert-E's current status in the pull request `TBA`
➡️ clear	Remove all comments from Bert-E from the history `TBA`

bert-e · 2019-12-11T15:07:58Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

Ebaneck · 2019-12-11T16:29:02Z

/approve

bert-e · 2019-12-11T16:29:08Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2019-12-11T16:31:08Z

Build failed

The build for commit did not succeed in branch feature/2072-Remove-support-for-Kubernetes-basic-auth.

The following options are set: approve

Ebaneck · 2019-12-11T17:55:40Z

/build

bert-e · 2019-12-11T17:55:43Z

Not implemented

This command will be implemented soon.

The following options are set: approve

bert-e · 2019-12-11T17:55:49Z

Build failed

The build for commit did not succeed in branch feature/2072-Remove-support-for-Kubernetes-basic-auth.

The following options are set: approve

bert-e · 2019-12-11T22:21:12Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2019-12-12T10:53:59Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.5

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4

Please check the status of the associated issue None.

Goodbye ebaneck.

Ebaneck requested a review from a team December 10, 2019 09:51

Ebaneck marked this pull request as ready for review December 10, 2019 09:53

TeddyAndrieux reviewed Dec 10, 2019

View reviewed changes

tests/post/features/salt_api.feature Outdated Show resolved Hide resolved

Ebaneck force-pushed the feature/2072-Remove-support-for-Kubernetes-basic-auth branch from 376ea23 to 4eb39f7 Compare December 10, 2019 16:54

gdemonet previously approved these changes Dec 11, 2019

View reviewed changes

docs/operation/account_administration.rst Outdated Show resolved Hide resolved

Ebaneck dismissed gdemonet’s stale review via 935625b December 11, 2019 12:00

Ebaneck added 3 commits December 11, 2019 15:56

kubernetes: Remove support for Basic Auth

84b8817

After the introduction of OIDC based authentication, we need to depreciate the use of basic auth in MetalK8s. For this to happen, this PR removes configurations related to basic authentication

salt: Remove basic auth from kubernetes_rbac

bd1f4ae

After the depreciation and removal of basic-auth in kubeapiserver, there is no need to continue to have support for basic auth in our salt/kubernetes module.

Ebaneck force-pushed the feature/2072-Remove-support-for-Kubernetes-basic-auth branch from 935625b to bd1f4ae Compare December 11, 2019 14:57

Ebaneck requested review from gdemonet and TeddyAndrieux December 11, 2019 14:58

gdemonet approved these changes Dec 11, 2019

View reviewed changes

bert-e merged commit bd1f4ae into development/2.5 Dec 12, 2019

bert-e deleted the feature/2072-Remove-support-for-Kubernetes-basic-auth branch December 12, 2019 10:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove support for kubernetes basic auth #2119

Remove support for kubernetes basic auth #2119

Ebaneck commented Dec 10, 2019

bert-e commented Dec 10, 2019

bert-e commented Dec 10, 2019

gdemonet left a comment

Ebaneck commented Dec 11, 2019

bert-e commented Dec 11, 2019

bert-e commented Dec 11, 2019

Ebaneck commented Dec 11, 2019

bert-e commented Dec 11, 2019

bert-e commented Dec 11, 2019

Ebaneck commented Dec 11, 2019

bert-e commented Dec 11, 2019

bert-e commented Dec 11, 2019

bert-e commented Dec 11, 2019

bert-e commented Dec 12, 2019

Remove support for kubernetes basic auth #2119

Remove support for kubernetes basic auth #2119

Conversation

Ebaneck commented Dec 10, 2019

bert-e commented Dec 10, 2019

Hello ebaneck,

bert-e commented Dec 10, 2019

Waiting for approval

gdemonet left a comment

Choose a reason for hiding this comment

Ebaneck commented Dec 11, 2019

bert-e commented Dec 11, 2019

Help page

Options

Commands

bert-e commented Dec 11, 2019

Waiting for approval

Ebaneck commented Dec 11, 2019

bert-e commented Dec 11, 2019

Waiting for approval

bert-e commented Dec 11, 2019

Build failed

Ebaneck commented Dec 11, 2019

bert-e commented Dec 11, 2019

Not implemented

bert-e commented Dec 11, 2019

Build failed

bert-e commented Dec 11, 2019

In the queue

bert-e commented Dec 12, 2019