Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts: Update Dex addon to version 2.23.0 #2437

Merged
merged 3 commits into from
Apr 23, 2020
Merged

charts: Update Dex addon to version 2.23.0 #2437

merged 3 commits into from
Apr 23, 2020

Conversation

Ebaneck
Copy link
Contributor

@Ebaneck Ebaneck commented Apr 20, 2020 •
edited

Component:

'charts', 'dex'

Context:

See #2429

Summary:

Bump Dex version to 2.23.0

Acceptance criteria:

Closes: #2429

@Ebaneck
renderer: Fix bad naming for __url__ in render.py
fbebaea 
Since we are simply justing magically escaping unquoted strings, urls
etc from jinja to yaml, the naming of the variable could be made
generic and explicit at thesame time

Now, let us use `__escape__` instead of `__url__``
@Ebaneck
charts: update dex to 2.23.0
f8dcb8d 
This chart was updated using:

```
$ rm -rf charts/dex/
$ helm repo update
$ helm fetch -d charts --untar stable/dex
```

Note: Local changes to the charts were made in `secret.yaml`

The chart was re-rendered using:

```
./charts/render.py dex --namespace metalk8s-auth charts/dex.yaml --service-config dex metalk8s-dex-config charts/dex/ >
salt/metalk8s/addons/dex/deployed/chart.sls
```
@Ebaneck
buildchain: bump dex version to 2.23.0
54f7296 
Closes: #2429
@Ebaneck Ebaneck requested a review from a team April 20, 2020 16:40
@bert-e
Copy link
Contributor

bert-e commented Apr 20, 2020

Hello ebaneck,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 20, 2020

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Apr 20, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@Ebaneck
Copy link
Contributor Author

Ebaneck commented Apr 21, 2020

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 21, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

TeddyAndrieux
TeddyAndrieux approved these changes Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but from what I see it's only a container image changes, so LGTM

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2020

Build failed

The build for commit did not succeed in branch w/2.6/improvement/2429-bump-dex-version-to-2.23.0.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2020

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.5

  • ✔️ development/2.6

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2020

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.5

  • ✔️ development/2.6

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4

Please check the status of the associated issue None.

Goodbye ebaneck.

@bert-e bert-e merged commit d26c909 into development/2.5 Apr 23, 2020
@bert-e bert-e deleted the improvement/2429-bump-dex-version-to-2.23.0 branch April 23, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-allard alexandre-allard alexandre-allard approved these changes

@TeddyAndrieux TeddyAndrieux TeddyAndrieux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ebaneck @bert-e @alexandre-allard @TeddyAndrieux