Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salt runner wait_minions report False positif #3031

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Salt runner wait_minions report False positif #3031

merged 2 commits into from
Jan 13, 2021

Conversation

TeddyAndrieux
Copy link
Collaborator

Component:

'salt'

Context:

              ----------
                        ID: Wait minion available
                  Function: salt.runner
                      Name: metalk8s_saltutil.wait_minions
                    Result: True
                   Comment: Runner function 'metalk8s_saltutil.wait_minions' executed.
                   Started: 18:35:17.972072
                  Duration: 109595.07 ms
                   Changes:   
                            ----------
                            return:
                                ----------
                                error:
                                    Minion failed to respond after 10 retries: node-1
                                result:
                                    False
              ----------

Summary:

Do not use result: False in salt runner as it will not report the failure in the state, instead raise an exception in the runner module

@TeddyAndrieux TeddyAndrieux added kind:bug Something isn't working complexity:easy Something that requires less than a day to fix topic:salt Everything related to SaltStack in our product labels Jan 13, 2021
@TeddyAndrieux TeddyAndrieux requested a review from a team January 13, 2021 09:16
@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux
salt: Make wait_minions runner raise if we have a failure
7355775 
A runner execution does not report a failure if we just set
`result: False` in the return dict, we need either to have
`Error: <msg>` in return dict, either to raise in the runner execution
module, second proposition has been choosen.
@TeddyAndrieux
salt: Fix wait_minions salt runner when no minion answer
2683c31 
If we no minion answer to the `test.ping` then the `minions` dict is
None and so we cannot use `len` on it
@TeddyAndrieux TeddyAndrieux force-pushed the bugfix/salt-runner-report-True-event-if-fail branch from 8388c48 to 2683c31 Compare January 13, 2021 09:18
@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

History mismatch

Merge commit #d6a7db8f3c4e41a57eff73f718f86e35acb7c3c5 on the integration branch
w/2.8/bugfix/salt-runner-report-True-event-if-fail is merging a branch which is neither the current
branch bugfix/salt-runner-report-True-event-if-fail nor the development branch
development/2.8.

It is likely due to a rebase of the branch bugfix/salt-runner-report-True-event-if-fail and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@TeddyAndrieux
Copy link
Collaborator Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

Build failed

The build for commit did not succeed in branch w/2.8/bugfix/salt-runner-report-True-event-if-fail.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.7

  • ✔️ development/2.8

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.7

  • ✔️ development/2.8

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit 2683c31 into development/2.7 Jan 13, 2021
@bert-e bert-e deleted the bugfix/salt-runner-report-True-event-if-fail branch January 13, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-allard alexandre-allard alexandre-allard approved these changes

@gdemonet gdemonet gdemonet approved these changes

Assignees
No one assigned
Labels
complexity:easy Something that requires less than a day to fix kind:bug Something isn't working topic:salt Everything related to SaltStack in our product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TeddyAndrieux @bert-e @alexandre-allard @gdemonet