Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Remove useLogoutEffect and display an error instead of logging out in case of an issue while authenticating on Salt API #3330

Merged
merged 6 commits into from
Apr 28, 2021
Merged

ui: Remove useLogoutEffect and display an error instead of logging out in case of an issue while authenticating on Salt API #3330

merged 6 commits into from
Apr 28, 2021

Conversation

JBWatenbergScality
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality commented Apr 27, 2021 •
edited
Loading

Component:

ui

Context:

In firefox a race condition led us to a state where logOut effect was called before the authentication being finished. Leading to an infinite login loop.

Summary:

It appears this is due to some optimisation while triggering useLoginEffect and useLogoutEffect. Also useLogoutEffect was only introduced to match an incorrect behaviour which is logging out the user when we fail to authenticate against Salt API. However most of the UI features can be used without Salt API.

Hence as useLogoutEffect was not really needed I purpose with this PR to get rid of it and switch to an error message being toasted when we can't be authenticated against Salt API.

Acceptance criteria:

Unit Tests and E2E cypress tests

@bert-e
Copy link
Contributor

bert-e commented Apr 27, 2021

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 27, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JBWatenbergScality JBWatenbergScality added the topic:ui UI-related issues label Apr 27, 2021
@JBWatenbergScality JBWatenbergScality force-pushed the bugfix/render-race-condition-on-firefox branch from bf9c926 to 3eeab65 Compare April 27, 2021 21:59
@JBWatenbergScality JBWatenbergScality marked this pull request as ready for review April 27, 2021 22:00
@JBWatenbergScality JBWatenbergScality requested a review from a team as a code owner April 27, 2021 22:00
@JBWatenbergScality JBWatenbergScality force-pushed the bugfix/render-race-condition-on-firefox branch 2 times, most recently from 8ceaa78 to 25be0ab Compare April 28, 2021 09:42
TeddyAndrieux and others added 2 commits April 28, 2021 12:16
@TeddyAndrieux @ChengYanJin
eve: Disable terraform plugins verification
eb93061 
Due to a bug in gpg signature for openstack terraform plugins, disable
plugins verification for now
This commit should really be reverted ASAP !
@JBWatenbergScality @ChengYanJin
ui: Remove useLogoutEffect and display an error instead of logging ou…
6e72453 
…t in case of an issue while authenticating on Salt API
@ChengYanJin ChengYanJin force-pushed the bugfix/render-race-condition-on-firefox branch from 25be0ab to 4414b3d Compare April 28, 2021 10:24
ChengYanJin
ChengYanJin previously approved these changes Apr 28, 2021
View reviewed changes
ChengYanJin
ChengYanJin previously approved these changes Apr 28, 2021
View reviewed changes
@JBWatenbergScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 28, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.9

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 28, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.9

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8

Please check the status of the associated issue None.

Goodbye jbwatenbergscality.

@bert-e bert-e merged commit 5182c13 into development/2.9 Apr 28, 2021
@bert-e bert-e deleted the bugfix/render-race-condition-on-firefox branch April 28, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengYanJin ChengYanJin ChengYanJin approved these changes

Assignees
No one assigned
Labels
topic:ui UI-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JBWatenbergScality @bert-e @ChengYanJin @TeddyAndrieux