Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-boto3 as a dependency to metalk8s-sosreport when rhel is 8 or superior #4328

Conversation

aprucolimartins
Copy link
Contributor

Add python3-boto3 as a dependency to metalk8s-sosreport when rhel is 8 or superior

It will allow to use sos report --upload-protocol s3 ..., and save reports directly in S3 buckets.

@aprucolimartins aprucolimartins requested a review from a team as a code owner May 23, 2024 07:05
@bert-e
Copy link
Contributor

bert-e commented May 23, 2024

Hello aprucolimartins,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 23, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@aprucolimartins aprucolimartins force-pushed the improvement/add_boto3_lib_to_support_sosreport_s3_storage branch from 09dd12a to ea3c612 Compare May 23, 2024 07:08
@aprucolimartins aprucolimartins changed the base branch from development/128.0 to development/127.0 May 23, 2024 07:11
@bert-e
Copy link
Contributor

bert-e commented May 23, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@aprucolimartins aprucolimartins force-pushed the improvement/add_boto3_lib_to_support_sosreport_s3_storage branch from 8f366af to 7bb878f Compare May 23, 2024 09:20
@aprucolimartins
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 23, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 23, 2024

Build failed

The build for commit did not succeed in branch improvement/add_boto3_lib_to_support_sosreport_s3_storage.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 24, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/127.0

  • ✔️ development/128.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye aprucolimartins.

The following options are set: approve

@bert-e bert-e merged commit 7bb878f into development/127.0 May 24, 2024
26 checks passed
@bert-e bert-e deleted the improvement/add_boto3_lib_to_support_sosreport_s3_storage branch May 24, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants