Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

scajyr is leaking scopePrototype #12

Closed
Offirmo opened this issue Sep 8, 2014 · 4 comments
Closed

scajyr is leaking scopePrototype #12

Offirmo opened this issue Sep 8, 2014 · 4 comments

Comments

@Offirmo
Copy link

Offirmo commented Sep 8, 2014

First thanks for your nice work.

When using scalyr/angular in mocha, mocha reports global leak detected: scopePrototype

And indeed, l. 722, scalyr/angular is leaking a global variable "scopePrototype"

Could this be fixed ? I think a simple var would do it but I'm not 100% sure since we're dealing with complex Angular code.

@Offirmo
Copy link
Author

Offirmo commented Sep 8, 2014

My bad, I installed scalyr through bower und it may have provided an old version. I'm investigating.

@Offirmo
Copy link
Author

Offirmo commented Sep 8, 2014

OK the issue has been fixed but not tagged.

Could the team please tag the 1.0.2 version ? Thanks.

@czerwingithub
Copy link
Contributor

Thanks for pointing that out we missed doing that. I've added a new
release with the 1.0.2 version.

-Steve

On Mon, Sep 8, 2014 at 1:21 AM, offirmo notifications@github.com wrote:

OK the issue has been fixed but not tagged.

Could the team please tag a 1.0.2 version with the latest sources ? Thanks.


Reply to this email directly or view it on GitHub
#12 (comment).

@Offirmo
Copy link
Author

Offirmo commented Sep 9, 2014

Perfect. Thanks on behalf of bower users !

@Offirmo Offirmo closed this as completed Sep 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants