Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional config path as an option #541

Merged
merged 1 commit into from
May 22, 2020
Merged

Add additional config path as an option #541

merged 1 commit into from
May 22, 2020

Conversation

imron
Copy link
Contributor

@imron imron commented May 19, 2020

Under kubernetes, it is not convenient to specify custom configuration snippets in the agent.d directory without overriding core configuration snippets.

This PR allows users to keep the default configuration snippets we provide, but also provide their own configuration snippets in an additional configuration directory.

This additional configuration directory is specified via an environment variable or a command line parameter.

If present, the agent will process all .json files in this directory and add them to its current configuration.

This only applies to the main agent, and not the agent config scripts.

@imron imron changed the title add additional config path as an option [WIP] add additional config path as an option May 19, 2020
@imron imron changed the title [WIP] add additional config path as an option Add additional config path as an option May 22, 2020
@imron imron marked this pull request as ready for review May 22, 2020 05:53
@imron imron requested a review from czerwingithub May 22, 2020 05:54
Copy link
Contributor

@czerwingithub czerwingithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, add a TODO and a youtrack ticket for supporting the extra config dir in the scalyr-agent-2-config script.

Under kubernetes, it is not convenient to specify custom configuration snippets
in the agent.d directory without overriding core configuration snippets.

This PR allows users to keep the default configuration snippets we provide, but
also provide their own configuration snippets in an additional configuration
directory.

This additional configuration directory is specified via an environment
variable or a command line parameter.

If present, the agent will process all .json files in this directory and add
them to its current configuration.

This only applies to the main agent, and not the agent config scripts.
@imron imron merged commit 26f8e0a into master May 22, 2020
@imron imron deleted the imron/agent-388 branch May 22, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants