Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbt-release and set the appropriate snapshot version for the 2.4.… #30

Merged
merged 1 commit into from Sep 14, 2016

Conversation

joelsonoda
Copy link
Collaborator

…x branch

@graingert
Copy link
Contributor

both scamandrill and scamandrill_2.4 should have the same release version. They're just two different packages right?

@graingert
Copy link
Contributor

maybe we should have these all in the same branch with:

.
├── scamandrill deps: scamandrill-core, play-ws % 2.5
├── scamandrill_2.4 deps: scamandrill-core, play-ws % 2.4
└── scamandrill-core

@codecov-io
Copy link

Current coverage is 95.86% (diff: 100%)

Merging #30 into 2.4.x will not change coverage

@@              2.4.x        #30   diff @@
==========================================
  Files            21         21          
  Lines           363        363          
  Methods         363        363          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            348        348          
  Misses           15         15          
  Partials          0          0          

Powered by Codecov. Last update cf69c04...2890bb0

@joelsonoda
Copy link
Collaborator Author

I was thinking that there would be a 2.4.x version for play 2.4.x and a 2.5.x version for play 2.5.x similar to https://github.com/leanovate/play-mockws

@graingert
Copy link
Contributor

ah that works, I thought we were on v3

@graingert graingert merged commit 2e5c6bd into 2.4.x Sep 14, 2016
@joelsonoda joelsonoda deleted the use-sbt-release-24 branch July 6, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants