Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Scaladex badge on ReadMe to show Scala version support #1163

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

rtyley
Copy link
Contributor

@rtyley rtyley commented Jul 9, 2021

This badge summarises which versions of Scala are supported by Scanamo (and what the latest Scanamo version is for each of those Scala versions):

scanamo Scala version support

More details on the badge format: scalacenter/scaladex#660

Copy link
Contributor

@regiskuckaertz regiskuckaertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The homepage needs to be updated too here: https://github.com/scanamo/scanamo/blob/master/docs/docs/index.md

This badge summarises which versions of Scala are supported by Scanamo (and
what the latest Scanamo version is for each of those Scala versions):

[![scanamo Scala version support](https://index.scala-lang.org/scanamo/scanamo/scanamo/latest-by-scala-version.svg)](https://index.scala-lang.org/scanamo/scanamo/scanamo)

More details on the badge format: scalacenter/scaladex#660
@rtyley rtyley force-pushed the scaladex-scala-version-support branch from 526d4d1 to 399e98a Compare July 10, 2021 11:55
@rtyley
Copy link
Contributor Author

rtyley commented Jul 10, 2021

The homepage needs to be updated too here: https://github.com/scanamo/scanamo/blob/master/docs/docs/index.md

Ah thanks, I missed that! I've amended the commit and force-pushed, should cover both places now.

@regiskuckaertz regiskuckaertz merged commit 5df0313 into master Jul 10, 2021
@regiskuckaertz regiskuckaertz deleted the scaladex-scala-version-support branch July 10, 2021 14:08
@rtyley
Copy link
Contributor Author

rtyley commented Jul 11, 2021

The homepage needs to be updated too here: https://github.com/scanamo/scanamo/blob/master/docs/docs/index.md

The homepage at https://www.scanamo.org/ doesn't seem to have updated (still shows the maven central badge), is that an automated process?

image

@regiskuckaertz
Copy link
Contributor

Hmm yes I think I never got around to adding it to the build and was doing it manually. Iirc it should be just a single sbt instruction now; with the only caveat that the CNAME file always seems to disappear for some reason and I had to recreate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants