-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI for the Scanamo repo not running since 15th June 2021 (travis-ci.org
decommisioned)
#1184
Comments
travis-ci.org
decommisioned)
https://travis-ci.com/github/scanamo/scanamo/jobs/530778506 This is the first time these checks have run in a while due to #1184
The CI build is running again, though it's currently failing due to a Monix/Cats conflict causing a
The Cats incompatibility would normally be shown by sbt v1.5 like this (but with the current version on the main branch, no warning is given, apparently because the dependencies are marked as
I was the one responsible for the Cats Effect v3.1.1 upgrade from v2.5.1 in PR #1166, but missed the Monix/CatsEffect conflict issue :( Currently, although an updated version of
|
Monix is not being updated nearly often enough anymore so I don't think it will remain relevant for long unless a new maintainer brings it back to life. |
This change updates to the latest version of `fs2-core`, which is now compatible with `cats-effect` v3.1.1 (introduced in #1166). Unfortunately there's not yet a version of `monix` that supports `cats-effect` v3.1.1, so we're dropping support for Monix for now - the actual implementation code within Scanamo for the Monix support is only 4 lines, so can probably be easily copied into an end-user project if it's needed! Sbt is capable of warning us about version conflicts in dependencies, but gave no warning of the `cats-effect` version conflict, I think because the `fs2-core` & `monix` dependencies were marked as already `Provided`. My guess as to why the `Provided` marker was used is that the `scanamo-cats-effect` artifact gave support for both `fs2-core` & `monix`, but in general a consuming project is likely to only be using one of those - by declaring the two dependencies as `Provided`, neither will be implicitly pulled in as a transitive dependency of `scanamo-cats-effect` when used in the end-user project- giving the end-user-project freedom to just explicitly declare a dependency on the one they want to use. As we've dropped Monix support, and there's now only `fs2-core` support, I've changed the `fs2-core` dependency to be explicit, which will give us the benefit of sbt version-conflict warnings in future. See #1184
…1187) This change updates to the latest version of `fs2-core`, which is now compatible with `cats-effect` v3.1.1 (introduced in #1166). Unfortunately there's not yet a version of `monix` that supports `cats-effect` v3.1.1, so we're dropping support for Monix for now - the actual implementation code within Scanamo for the Monix support is only 4 lines, so can probably be easily copied into an end-user project if it's needed! Sbt is capable of warning us about version conflicts in dependencies, but gave no warning of the `cats-effect` version conflict, I think because the `fs2-core` & `monix` dependencies were marked as already `Provided`. My guess as to why the `Provided` marker was used is that the `scanamo-cats-effect` artifact gave support for both `fs2-core` & `monix`, but in general a consuming project is likely to only be using one of those - by declaring the two dependencies as `Provided`, neither will be implicitly pulled in as a transitive dependency of `scanamo-cats-effect` when used in the end-user project- giving the end-user-project freedom to just explicitly declare a dependency on the one they want to use. As we've dropped Monix support, and there's now only `fs2-core` support, I've changed the `fs2-core` dependency to be explicit, which will give us the benefit of sbt version-conflict warnings in future. See #1184
With PR #1187 merged, the Travis-CI build is now passing again! I'm not sure if this is directly related, but a nice effect of this is that the |
Scanamo has a
.travis.yml
file, but is currently on travis-ci.org (ie https://travis-ci.org/github/scanamo/scanamo), which stopped doing builds on 15th June 2021:Although commits since then in the Scanamo repo have been marked with a green tick, this was actually just due to the 'Mergify' check passing (tho' not taking any action):
...to transfer to travis-ci.com (which now also accommodates public open-source repos for free) we'd need to hit the migrate option (and sign up to the beta?) on this page https://travis-ci.com/organizations/scanamo/migrate :
I'm not able to do this, as although I'm an 'Admin' on the GitHub repo (https://github.com/scanamo/scanamo/settings/access) I'm not an 'owner' on the GitHub organisation: https://github.com/orgs/scanamo/people
Could I be made an owner on the GitHub organisation? I can then perform the switchover from travis-ci.org to travis-ci.com. I realise also that GitHub Actions is also a popular option these days, personally I'd prefer the switch from
travis-ci.[org -> com]
as it feels like a more minimal change to me.cc @regiskuckaertz @davidfurey
The text was updated successfully, but these errors were encountered: