Fix #1184 (cats-effect version conflict) by dropping Monix for now
#1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates to the latest version of `fs2-core`, which is now compatible with `cats-effect` v3.1.1 (introduced in #1166). Unfortunately there's not yet a version of `monix` that supports `cats-effect` v3.1.1, so we're dropping support for Monix for now - the actual implementation code within Scanamo for the Monix support is only 4 lines, so can probably be easily copied into an end-user project if it's needed! Sbt is capable of warning us about version conflicts in dependencies, but gave no warning of the `cats-effect` version conflict, I think because the `fs2-core` & `monix` dependencies were marked as already `Provided`. My guess as to why the `Provided` marker was used is that the `scanamo-cats-effect` artifact gave support for both `fs2-core` & `monix`, but in general a consuming project is likely to only be using one of those - by declaring the two dependencies as `Provided`, neither will be implicitly pulled in as a transitive dependency of `scanamo-cats-effect` when used in the end-user project- giving the end-user-project freedom to just explicitly declare a dependency on the one they want to use. As we've dropped Monix support, and there's now only `fs2-core` support, I've changed the `fs2-core` dependency to be explicit, which will give us the benefit of sbt version-conflict warnings in future. See #1184
regiskuckaertz
approved these changes
Aug 15, 2021
regiskuckaertz
deleted the
fix-cats-effect-version-conflict-by-dropping-monix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates to the latest version of
fs2-core, which is now compatible withcats-effectv3.1.1 (introduced in#1166). Unfortunately there's not yet a version of
monixthat supportscats-effectv3.1.1, so we're dropping support for Monix for now - the actual implementation code within Scanamo for the Monix support is only 4 lines, so can probably be easily copied into an end-user project if it's needed!Sbt is capable of warning us about version conflicts in dependencies, but gave no warning of the
cats-effectversion conflict, I think because thefs2-core&monixdependencies were marked as alreadyProvided. My guess as to why theProvidedmarker was used is that thescanamo-cats-effectartifact gave support for bothfs2-core&monix,but in general a consuming project is likely to only be using one of those - by declaring the two dependencies asProvided, neither will be implicitly pulled in as a transitive dependency ofscanamo-cats-effectwhen used in the end-user project - giving the end-user-project freedom to just explicitly declare a dependency on the one they want to use (another approach to this problem would be to split thescanamo-cats-effectartifact into two separate modules). As we've dropped Monix support, and there's now onlyfs2-coresupport, I've changed thefs2-coredependency to be explicit, which will give us the benefit of sbt version-conflict warnings in future.See also #1184