Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 2: How to show test results in the html report #161

Closed
camilamaia opened this issue Jun 4, 2020 · 16 comments
Closed

ADR 2: How to show test results in the html report #161

camilamaia opened this issue Jun 4, 2020 · 16 comments
Assignees
Labels
ADR Architecture Decision Review
Milestone

Comments

@camilamaia
Copy link
Member

camilamaia commented Jun 4, 2020

Architecture Decision Review - ADR

  • How are we going to show the tests in the html report
  • Which color should we use?
  • How are we going to show each test case?
  • How are we going to show if a test passed?
  • How are we going to show if a test failed?
  • Should we use HTTP methods with color? Yes or No?

This discussion started here

Related ADR: #164

@camilamaia camilamaia added the ADR Architecture Decision Review label Jun 4, 2020
@camilamaia camilamaia changed the title ARD 2: How to show test results in the html and md reports ADR 2: How to show test results in the html and md reports Jun 4, 2020
@camilamaia camilamaia changed the title ADR 2: How to show test results in the html and md reports ADR 2: How to show test results in the html report Jun 4, 2020
@camilamaia camilamaia added this to To do in Release 1.0.0 via automation Jun 10, 2020
@camilamaia camilamaia added this to the Release 1.0.0 milestone Jun 10, 2020
@camilamaia camilamaia removed this from To do in Release 1.0.0 Jun 15, 2020
@camilamaia camilamaia added this to To do in Release 1.0.0 via automation Jun 15, 2020
@camilamaia
Copy link
Member Author

camilamaia commented Jun 19, 2020

Basically we have three different test status we need to show

  1. The overview. If all tests passed. Or, if any test failed

image

If all tests passed, the test summary should, somehow, show that everything is ok and there is no need to check anything else. It is all green.

  1. The Endpoint. We need to show if all tests for that specific endpoint passed (or, if any failed)

image

Here it is important to provide somehow an easy and fast way for the user to find which endpoint has a failing test. Let's say we have a report with dozens of endpoints. We don't want the user opening all the endpoints trying to find which one failed.

Something written would be a solution. Let's say there is something like this

image

The user can easily use ctrl + f and search for [failed] to find the endpoints with failing tests.

  1. The test itself.

image


We are using different colors for each HTTP method. We want to make clear that they are different.

image

But, as @barbosa mentioned here, "green/yellow/red colors may give the impression of success/failure for each of the requests being executed."

So how we can show this difference without making this impression of success/failure/skipped? Which colors should we use? I tried some pastel colors, but I did not like the ones I picked

image

Current we only support five HTTP methods, but there are 9 in total.


In summary, it would be nice to discuss:

  1. What is the best way to show the overview status?
  2. What is the best way to show the endpoint status?
  3. What is the best way to show the test status?
  4. What is the best way to differentiate the HTTP methods?

ps: please, see the comment above with some suggestions

@djalmaaraujo
Copy link
Contributor

@camilamaia @barbosa
Hey, that's a good discussion. Here's what I would prefer to see in this case:

  • I would suggest red/green for the main status of the runner (PASSED/FAILED)
  • One-color only for the HTTP methods. I am not sure if the different colors make sense for the report, to be honest. So maybe we could use BLUE (maybe) since blue is not a TRAFFIC color (red/green/yellow)
  • For HTTP status 200/404/etc, I would follow the standard industry: 200/2** goes GREEN, anything bad 400/500, etc goes red.

I can provide the palette for this if you agree.

@camilamaia
Copy link
Member Author

Versions with images:

Version 1

version1_closed
version1_opened

Version 2

version2_closed
version2_opened

Version 3

version3_closed
version3_opened

Version 4

version4_closed
version4_opened

Version 5

version5_closed
version5_opened

Version 6

version6_closed
version6_opened

@gillianomenezes
Copy link
Contributor

gillianomenezes commented Jun 19, 2020

@camilamaia @barbosa
Hey, that's a good discussion. Here's what I would prefer to see in this case:

  • I would suggest red/green for the main status of the runner (PASSED/FAILED)
  • One-color only for the HTTP methods. I am not sure if the different colors make sense for the report, to be honest. So maybe we could use BLUE (maybe) since blue is not a TRAFFIC color (red/green/yellow)
  • For HTTP status 200/404/etc, I would follow the standard industry: 200/2** goes GREEN, anything bad 400/500, etc goes red.

I can provide the palette for this if you agree.

I agree with this approach. IMHO the HTTP methods in black bold seem better. This is why I vote in the first option, @camilamaia.

@barbosa
Copy link
Member

barbosa commented Jun 20, 2020

@camilamaia @barbosa
Hey, that's a good discussion. Here's what I would prefer to see in this case:

  • I would suggest red/green for the main status of the runner (PASSED/FAILED)
  • One-color only for the HTTP methods. I am not sure if the different colors make sense for the report, to be honest. So maybe we could use BLUE (maybe) since blue is not a TRAFFIC color (red/green/yellow)
  • For HTTP status 200/404/etc, I would follow the standard industry: 200/2** goes GREEN, anything bad 400/500, etc goes red.

I can provide the palette for this if you agree.

Yeah, I agree with this except for the last item. I believe color variation should be used for one thing and one thing only: indicate success or failure of test results.

I would keep both HTTP methods and status codes in black.

Mixing red/green in more than one context would cause confusion, I think.

@camilamaia
Copy link
Member Author

camilamaia commented Jun 21, 2020

@djalmaaraujo @gillianomenezes and @barbosa, thank you very much for your feedbacks and opinions. Based on then, I created a new version. What do you think?

Failed Closed

failed-closed

Failed Opened

failed-opened

Passed Closed

passed-closed

Passed Opened

passed-opened

@camilamaia
Copy link
Member Author

@djalmaaraujo give me some help! Look how it is now:

passed
error-opened

@camilamaia
Copy link
Member Author

@gillianomenezes and @barbosa can I close this ticket? Do you have any other opinions? Thanks!

@barbosa
Copy link
Member

barbosa commented Jun 25, 2020

Screen Shot 2020-06-24 at 8 39 44 PM

it seems the icons are not vertically centered but we can fix this later

@camilamaia
Copy link
Member Author

camilamaia commented Jun 25, 2020

Screen Shot 2020-06-24 at 8 39 44 PM

it seems the icons are not vertically centered but we can fix this later

Great catch 🔍 👀
@barbosa I created a new issue for that: #190

@camilamaia
Copy link
Member Author

@GitVitor check this issue here! It might help you with the new changes on the report 🎨

@GitVitor
Copy link
Contributor

@camilamaia thanks, i had never seen this ADR before;

Just to document, i had some thoughts about how we could improve our UI;

Below a list with some changes that i have work:

  1. Change P(assed) or F(ailed) icon;
  2. Change font-family to use Gotham;
  3. Use diferent colors to represent each HTTP Method (Image 1);
  4. Make request content, request response and request test visually grouped (Image 2);
  5. Change Green to use the following hex #48c78e;
  6. Change Red to use the following hex #f14668;

Image 1
image

Image 2
image

@GitVitor
Copy link
Contributor

Based on comments that was sent here, maybe we could apply following changes:

  1. Change P(assed) or F(ailed) icon;
  2. Change font-family to use Gotham;
    Use diferent colors to represent each HTTP Method;
    Make request content, request response and request test visually grouped;
  3. Change Green to use the following hex #48c78e;
  4. Change Red to use the following hex #f14668;

@camilamaia
Copy link
Member Author

@GitVitor I love the new ideas! The only concern I had was the colors, as you mentioned before. But I would keep the number 4 Make request content, request response and request test visually grouped (Image 2); I think it is good to see them together. Any reason to not implement it?

Thanks again!

@GitVitor
Copy link
Contributor

Oh number 4 make sense and could be implemented, i make some mistake on remove it 😄

@GitVitor GitVitor mentioned this issue Sep 9, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR Architecture Decision Review
Projects
No open projects
Release 1.0.0
  
Done
Development

No branches or pull requests

5 participants