New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR 2: How to show test results in the html report #161
Comments
I did some tests, they are all ugly 😂 But maybe we can get some ideas of what works and what doesn't work: https://github.com/scanapi/scanapi/blob/adr2/testing_reports/version1.html I can't attach HTML files, that is why a created a temporary branch just to load this tests. @barbosa @djalmaaraujo @gillianomenezes any thought? |
Basically we have three different test status we need to show
If all tests passed, the test summary should, somehow, show that everything is ok and there is no need to check anything else. It is all green.
Here it is important to provide somehow an easy and fast way for the user to find which endpoint has a failing test. Let's say we have a report with dozens of endpoints. We don't want the user opening all the endpoints trying to find which one failed. Something written would be a solution. Let's say there is something like this The user can easily use
We are using different colors for each HTTP method. We want to make clear that they are different. But, as @barbosa mentioned here, "green/yellow/red colors may give the impression of success/failure for each of the requests being executed." So how we can show this difference without making this impression of success/failure/skipped? Which colors should we use? I tried some pastel colors, but I did not like the ones I picked Current we only support five HTTP methods, but there are 9 in total. In summary, it would be nice to discuss:
ps: please, see the comment above with some suggestions |
@camilamaia @barbosa
I can provide the palette for this if you agree. |
I agree with this approach. IMHO the HTTP methods in black bold seem better. This is why I vote in the first option, @camilamaia. |
Yeah, I agree with this except for the last item. I believe color variation should be used for one thing and one thing only: indicate success or failure of test results. I would keep both HTTP methods and status codes in black. Mixing red/green in more than one context would cause confusion, I think. |
@djalmaaraujo @gillianomenezes and @barbosa, thank you very much for your feedbacks and opinions. Based on then, I created a new version. What do you think? Failed ClosedFailed OpenedPassed ClosedPassed Opened |
@djalmaaraujo give me some help! Look how it is now: |
@gillianomenezes and @barbosa can I close this ticket? Do you have any other opinions? Thanks! |
@GitVitor check this issue here! It might help you with the new changes on the report 🎨 |
@camilamaia thanks, i had never seen this ADR before; Just to document, i had some thoughts about how we could improve our UI; Below a list with some changes that i have work:
|
Based on comments that was sent here, maybe we could apply following changes:
|
@GitVitor I love the new ideas! The only concern I had was the colors, as you mentioned before. But I would keep the number 4 Thanks again! |
Oh number 4 make sense and could be implemented, i make some mistake on remove it 😄 |
Architecture Decision Review - ADR
This discussion started here
Related ADR: #164
The text was updated successfully, but these errors were encountered: