Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Html template #157

Merged
merged 8 commits into from Jun 4, 2020
Merged

New Html template #157

merged 8 commits into from Jun 4, 2020

Conversation

djalmaaraujo
Copy link
Contributor

@djalmaaraujo djalmaaraujo commented Jun 4, 2020

New HTML template using jinja. 馃コ

The reason the CSS is inline is because we want to avoid adding useless dependencies to the project.

image

Closes #61 #57

@github-actions
Copy link

github-actions bot commented Jun 4, 2020

@djalmaaraujo your pull request is missing a changelog!

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #157 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   92.37%   92.42%   +0.04%     
==========================================
  Files          12       12              
  Lines         459      462       +3     
==========================================
+ Hits          424      427       +3     
  Misses         35       35              
Impacted Files Coverage 螖
scanapi/reporter.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update de52ea9...87edd2f. Read the comment docs.

@camilamaia
Copy link
Member

camilamaia commented Jun 4, 2020

With Project Name:
image

Without Project Name:
image

Copy link
Member

@barbosa barbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good.

Something that comes to my mind now is that if these green/yellow/red colors may give the impression of success/failure for each of the requests being executed.

@camilamaia
Copy link
Member

This is looking good.

Something that comes to my mind now is that if these green/yellow/red colors may give the impression of success/failure for each of the requests being executed.

Good point. We will bring tests results to this report soon. So we will display in a clear way if the test pass or failed. Maybe a big check or x before the http method. Or the border of each row in green if passed, or red if not. We need to think more about it.

But I believe, then, we will not have this confusion. What do you think?

@camilamaia
Copy link
Member

Also, you can check an example of the generated report here: https://github.com/scanapi/scanapi-examples/blob/master/scanapi-demo/scanapi-report.html

@barbosa
Copy link
Member

barbosa commented Jun 4, 2020

Yeah, that's something to think about. Especially if we plan to bring test results to the same report.

Red to me looks like something errored.

@camilamaia
Copy link
Member

camilamaia commented Jun 4, 2020

Yeah, that's something to think about. Especially if we plan to bring test results to the same report.

Red to me looks like something errored.

I can create a new "ADR" to discuss about the tests results in the reports (both html and md)

@camilamaia
Copy link
Member

@barbosa #161

Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀

@camilamaia camilamaia merged commit d50fdd1 into master Jun 4, 2020
@camilamaia camilamaia deleted the html-template branch June 4, 2020 20:51
@camilamaia camilamaia mentioned this pull request Jun 10, 2020
2 tasks
@camilamaia camilamaia mentioned this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make html report pretty
6 participants