Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change project-name, hide-request and hide-response to use underscore #228

Closed
camilamaia opened this issue Jul 25, 2020 · 1 comment · Fixed by #236
Closed

Change project-name, hide-request and hide-response to use underscore #228

camilamaia opened this issue Jul 25, 2020 · 1 comment · Fixed by #236
Assignees
@Pradhvan
Labels
Good First Issue Good for newcomers or first time contributors.
Projects
EuroPython 2020 Sprint

Comments

@camilamaia
Copy link
Member

Change project-name, hide-request and hide-response to use underscore

  • project_name instead of project-name
  • hide_request instead of hide-request
  • hide_response instead of hide-response

scanapi/scanapi/reporter.py

Line 36 in 55e30aa

"project_name": settings.get("project-name", ""),

scanapi/scanapi/hide_utils.py

Lines 14 to 15 in 55e30aa

request_settings = report_settings.get("hide-request", {})
response_settings = report_settings.get("hide-response", {})

@camilamaia camilamaia added the Good First Issue Good for newcomers or first time contributors. label Jul 25, 2020
@camilamaia camilamaia added this to To do in EuroPython 2020 Sprint via automation Jul 25, 2020
@Pradhvan
Copy link
Member

@camilamaia I can pick this up ✋

@Pradhvan Pradhvan mentioned this issue Jul 26, 2020
Merged
Pradhvan added a commit to Pradhvan/scanapi that referenced this issue Jul 26, 2020
@Pradhvan
Updated naming convetions to use underscore.
65734d8 
* reporter.py: `project-name` -> `project_name`
* hide_utils.py: `hide-reques` -> `hide_request`
* hide_utils.py: `hide-response` -> `hide_response`

closes scanapi#228
EuroPython 2020 Sprint automation moved this from To do to Done Jul 26, 2020
camilamaia pushed a commit that referenced this issue Jul 26, 2020
@Pradhvan
Updated naming convetions to use underscore. (#236)
1987dfb 
* reporter.py: `project-name` -> `project_name`
* hide_utils.py: `hide-reques` -> `hide_request`
* hide_utils.py: `hide-response` -> `hide_response`

closes #228
@camilamaia camilamaia mentioned this issue Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pradhvan Pradhvan

Labels
Good First Issue Good for newcomers or first time contributors.
Projects
No open projects
EuroPython 2020 Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated naming convetions to use underscore Pradhvan/scanapi
2 participants
@camilamaia @Pradhvan