-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Architecture #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67e86ec
to
533a204
Compare
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 90.18% 87.95% -2.24%
==========================================
Files 14 15 +1
Lines 377 415 +38
==========================================
+ Hits 340 365 +25
- Misses 37 50 +13
Continue to review full report at Codecov.
|
45e8368
to
af91d0e
Compare
990c4dc
to
e84a45c
Compare
barbosa
approved these changes
Apr 21, 2020
e84a45c
to
b2b7408
Compare
b2b7408
to
7279b56
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First of all, sorry for the biggest PR ever 馃悩 Next time I will create another branch and smaller PRs.
This refactors the whole code to use a cleaner and better recursion mechanism.
Also, it changes a bit the syntax of the API specification to make it easier the recursion. This way, we don't need to handle the root cases and different keywords from different scopes with the same meaning (like
base_url
andpath
).Summary:
Issues
Add hide sensitive info to body #31