Skip to content

Conversation

barbosa
Copy link
Member

@barbosa barbosa commented May 3, 2020

Closes #58

@barbosa barbosa force-pushed the custom-template branch 2 times, most recently from 7a9a289 to 5f0dccf Compare May 9, 2020 22:59
@codecov-io
Copy link

codecov-io commented May 9, 2020

Codecov Report

Merging #126 into master will increase coverage by 7.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   84.02%   91.33%   +7.31%     
==========================================
  Files          11       11              
  Lines         388      381       -7     
==========================================
+ Hits          326      348      +22     
+ Misses         62       33      -29     
Impacted Files Coverage Δ
scanapi/reporter.py 100.00% <100.00%> (+72.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a9354...b0cdac6. Read the comment docs.

@barbosa barbosa marked this pull request as ready for review May 9, 2020 23:09
@barbosa barbosa force-pushed the custom-template branch from 5f0dccf to 0e2ebc9 Compare May 9, 2020 23:18
@barbosa barbosa requested a review from camilamaia May 9, 2020 23:19
Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌👏👏👏


with open(self.output_path, "w", newline="\n") as doc:
doc.write(content)

logger.info("The documentation was generated successfully.")
logger.info(f"It is available at {self.output_path}")

def hide_headers_info(self, responses):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to erase this part in the refactor. Thank you very much!

@@ -0,0 +1,77 @@
import pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this will increase the coverage a lot! 😍😍😍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! We didn't have any tests for the reporter yet so it's increasing a good 7.31% ⬆️

@camilamaia camilamaia requested a review from gillianomenezes May 9, 2020 23:39
@barbosa barbosa merged commit 885957a into master May 10, 2020
@barbosa barbosa deleted the custom-template branch May 10, 2020 00:14
camilamaia added a commit that referenced this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to use custom templates
3 participants