Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: include workflow checking from missing changelog #134

Merged
merged 2 commits into from May 10, 2020

Conversation

barbosa
Copy link
Member

@barbosa barbosa commented May 10, 2020

We may be able to test only on future PRs though.

Closes #94

@barbosa barbosa requested a review from camilamaia May 10, 2020 23:43
@github-actions
Copy link

@barbosa your pull request is missing a changelog!

@barbosa
Copy link
Member Author

barbosa commented May 10, 2020

or maybe not :)

@camilamaia
Copy link
Member

Wow, this was fast, dude!! :sonic:

@codecov-io
Copy link

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          11       11           
  Lines         381      381           
=======================================
  Hits          348      348           
  Misses         33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885957a...8fbcf95. Read the comment docs.

@barbosa barbosa merged commit 55037ca into master May 10, 2020
@barbosa barbosa deleted the actions/missing-changelog branch May 10, 2020 23:48
@camilamaia camilamaia mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert if CHANGELOG.md was not updated
3 participants