New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default template to html #173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 12 12
Lines 462 462
=======================================
Hits 427 427
Misses 35 35
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may also want to add HTML as the default option on __init__.py
@barbosa I believe we cannot do that. If reporter is set as |
@camilamaia Hmm I see. So maybe we have a design issue here? Some arguments have their default value set via |
@barbosa maybe... we have a priority here: 1st: options from click https://github.com/scanapi/scanapi/blob/master/scanapi/settings.py#L40-L41 Talking with examples: If i set That is why we cannot use the default values from click. This logic is applied for all arguments. Do you see this as a problem? Can you think in a different way to do that? Thanks! |
@barbosa I will merge this, but let's keep discussing it here, ok? If we think something needs to be done, I can create a new issue for it. |
Change default template to html. Closes #159