Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default template to html #173

Merged
merged 2 commits into from Jun 12, 2020
Merged

Change default template to html #173

merged 2 commits into from Jun 12, 2020

Conversation

camilamaia
Copy link
Member

Change default template to html. Closes #159

@camilamaia camilamaia self-assigned this Jun 8, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          12       12           
  Lines         462      462           
=======================================
  Hits          427      427           
  Misses         35       35           
Impacted Files Coverage Δ
scanapi/settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50fdd1...d83aaa4. Read the comment docs.

Copy link
Member

@barbosa barbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may also want to add HTML as the default option on __init__.py

@camilamaia
Copy link
Member Author

You may also want to add HTML as the default option on __init__.py

@barbosa I believe we cannot do that. If reporter is set as markdown in the config file and not via console, we would overwrite it with html anyway.

@barbosa
Copy link
Member

barbosa commented Jun 11, 2020

@camilamaia Hmm I see. So maybe we have a design issue here? Some arguments have their default value set via click and others via Settings, is that it?

@camilamaia
Copy link
Member Author

camilamaia commented Jun 11, 2020

@barbosa maybe... we have a priority here:

1st: options from click
2nd: options from config path

https://github.com/scanapi/scanapi/blob/master/scanapi/settings.py#L40-L41

Talking with examples: If i set key x in the config file as 1, and i set the same key x via console as 2, the program should consider the console more important and set key x as 2

That is why we cannot use the default values from click. This logic is applied for all arguments.

Do you see this as a problem? Can you think in a different way to do that? Thanks!

@camilamaia
Copy link
Member Author

@barbosa I will merge this, but let's keep discussing it here, ok? If we think something needs to be done, I can create a new issue for it.

@camilamaia camilamaia merged commit 9d65e14 into master Jun 12, 2020
@camilamaia camilamaia deleted the default-html branch June 12, 2020 21:29
@camilamaia camilamaia mentioned this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change HTML report to default
4 participants