Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertically centered status icons #195

Merged
merged 2 commits into from Jun 26, 2020
Merged

Vertically centered status icons #195

merged 2 commits into from Jun 26, 2020

Conversation

abreumatheus
Copy link
Member

@abreumatheus abreumatheus commented Jun 25, 2020 •
edited

Fixed

@abreumatheus abreumatheus reopened this Jun 25, 2020
@abreumatheus abreumatheus mentioned this pull request Jun 26, 2020
Closed
camilamaia
camilamaia approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR!! 🙇‍♀️

Just a minor detail, but the way you prefer is good for me :)

scanapi/templates/html.jinja
@@ -205,6 +205,9 @@
color: white;
font-size: 14px;
line-height: 20px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
line-height: 20px;
line-height: 19px;

This is how it is rendering with your changes and line height 20px:

image

I tried to reduce 1px of the line height and this is the result:

image

What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, with 20px it seems more aligned with the center of the arrow icon. It would be nice to hear other opinions on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. 20 seems to better align with the arrow and 19/18 with the status code.

Anyways - I think this is good 👍

@barbosa barbosa merged commit ecf5c95 into scanapi:master Jun 26, 2020
@abreumatheus abreumatheus deleted the vertically_center_status_icons branch June 30, 2020 17:57
@camilamaia camilamaia mentioned this pull request Jul 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbosa barbosa barbosa approved these changes

@camilamaia camilamaia camilamaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abreumatheus @barbosa @camilamaia