-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add poetry #207
add poetry #207
Conversation
@marcuxyz your pull request is missing a changelog! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcuxyz First of all, thank you very much for the PR! 🙇♀️
To pass in the checks, you would need to:
- Format the files using black
- Add an entry to the CHANGELOG.md file.
- Change the publish to pypi github action, because it uses the old way with setup.py. I would suggest to use this action: https://github.com/marketplace/actions/publish-python-poetry-package
Please, let me know if you need help with any of these points!
@marcuxyz Hmmm I was thinking that probably we need to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know poetry
. Seems nice.
@camilamaia your pull request is missing a changelog! |
169f5ef
to
3ac93f3
Compare
4f1cbc4
to
d18a99c
Compare
d18a99c
to
cef1d57
Compare
Close #140
Close #141
Close #150