New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render JSON content with indentation #213
Conversation
Just as observation: I used a javascript library to render the json in a "interactive" way, but if the user disables javascript on the browser (or for some reason the browser or device doesn't support javascript) it won't break the report, it will just fall back to plain text. |
Nice! Do you have a screenshot of how that's being rendered, @abreumatheus ? |
Sure do! |
@abreumatheus hi! I tested it here for the PokèAPI and it worked perfectly, beautiful! ⭐ Super cool feature collapsing indeed, I love it. It worked for firefox, chrome and safari 👏 But when I tested for the https://github.com/scanapi/scanapi/blob/master/CONTRIBUTING.md#clone-scanapi-examples $ source ../examples/demo-api/.env
$ poetry run scanapi ../examples/demo-api/api.yaml -c ../examples/demo-api/.scanapi.yaml -o ../examples/demo-api/scanapi-report.html I don't know if it is a problem with our demo-api... 🤷♀️ |
@camilamaia I will check it here and see if there is anything wrong with both :) |
@abreumatheus your pull request is missing a changelog! |
@camilamaia The problem is actually with the demo api not outputing valid JSON in some endpoints, like the first one where the response is |
@camilamaia @barbosa Hi guys! Just updated the script, and now it's non blocking. If it encounters non valid JSON it just goes to the next response. Could you test it again with the demo api? |
@abreumatheus it worked perfectly! Ty very much!. This is feature is really important |
Refers to: [#205 ]
Added