Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the api top-level key #231

Merged
merged 1 commit into from Jul 26, 2020
Merged

Remove the api top-level key #231

merged 1 commit into from Jul 26, 2020

Conversation

supakeen
Copy link
Contributor

@supakeen supakeen commented Jul 26, 2020

In #209 it was suggested to remove the top-level api key, this PR removes that but it does not deal with the possibility of it being there. Since for the previous PRs we let things ride regarding backwards compatibility I wonder if it's still necessary for this PR.

Closes #209

@camilamaia camilamaia requested review from a team July 26, 2020 11:16
Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamaia
Copy link
Member

PR that changes the examples: scanapi/examples#6

@camilamaia camilamaia merged commit 799e832 into scanapi:master Jul 26, 2020
@camilamaia camilamaia mentioned this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove api key
2 participants