Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hide body sensitive info #238

Merged
merged 1 commit into from Jul 26, 2020
Merged

Fix hide body sensitive info #238

merged 1 commit into from Jul 26, 2020

Conversation

camilamaia
Copy link
Member

Fix hide body sensitive info

When trying to hide body sensitive information:

report:
  hide_request:
    headers:
      - Authorization
    body:
      - get_token

the user is facing this error:

a bytes-like object is required, not 'str'

This PR fixes it. Closes #235

@github-actions
Copy link

@camilamaia your pull request is missing a changelog!

@camilamaia camilamaia marked this pull request as ready for review July 26, 2020 14:55
@camilamaia camilamaia requested review from a team July 26, 2020 14:55
@camilamaia camilamaia added this to In progress in EuroPython 2020 Sprint via automation Jul 26, 2020
EuroPython 2020 Sprint automation moved this from In progress to Reviewer approved Jul 26, 2020
@5pence 5pence merged commit 505bd2b into master Jul 26, 2020
EuroPython 2020 Sprint automation moved this from Reviewer approved to Done Jul 26, 2020
@5pence 5pence deleted the 235 branch July 26, 2020 16:04
@camilamaia camilamaia mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5pence 5pence 5pence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
EuroPython 2020 Sprint
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for hiding selected request body
2 participants
@camilamaia @5pence