Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update report summary test location #479

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Conversation

GitVitor
Copy link
Contributor

@GitVitor GitVitor commented Aug 1, 2021

Description

update report summary test location
update report classes following BEMCSS pattern
close unclosed html tags

Motivation behind this PR?

478

What type of change is this?

Feature

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.

Issue

Closes #478

update report classes following BEMCSS pattern
close unclosed html tags
@GitVitor GitVitor marked this pull request as ready for review August 2, 2021 17:40
@GitVitor GitVitor requested review from a team as code owners August 2, 2021 17:40
Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution!!

I left just a minor suggestion related to the CHANGELOG. Otherwise everything is great ⭐️ This position is much better 🎨

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
GitVitor and others added 2 commits August 3, 2021 11:33
Co-authored-by: Camila Maia <cmaiacd@gmail.com>
Co-authored-by: Camila Maia <cmaiacd@gmail.com>
@GitVitor
Copy link
Contributor Author

GitVitor commented Aug 3, 2021

Thank you very much for the contribution!!

I left just a minor suggestion related to the CHANGELOG. Otherwise everything is great ⭐️ This position is much better 🎨

Suggestion merged

@camilamaia camilamaia merged commit 2ae8ef4 into scanapi:main Aug 3, 2021
@camilamaia
Copy link
Member

@GitVitor Congrats for your first PR merged! Thank you very much!

I am going to send you an invite to join the ScanAPI org on GitHub 🚀 We invite everyone that has contributed with a merged PR in any of our repos. Here you can check our Contributing Guidelines so you can understand better how it works.

And once again, thank you! 🙇‍♀️

@camilamaia camilamaia mentioned this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change tests summary report location
2 participants