New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue/512 #515
Fix/issue/512 #515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.
In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.
We hope to see you around!
I had no idea black did not run on saving (I have this enabled on all my repositories by default and thus, did not pay real attention to it). The black linting should pass now. As for the DeepSource, it complains about using eval. Which it does so correctly, but this is the bread and butter of scanapi, so I was wondering how to add an exception to this hook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shifqu, thanks for the PR.
Looks great, nice approach :)
I notice there are some other commits included in the PR, not only your changed.
Could you please adjust it so we can merge?
Thanks!!
Requested changes have been pushed. I also squashed the commits |
Co-authored-by: shifqu <shifqu@softllama.net>
Congrats on your first merged PR! 🌟 Thank you very much! I am going to send you an invite to join the ScanAPI org on GitHub 🚀 We invite everyone that has contributed with a merged PR in any of our repositories. Here you can check our Contributing Guidelines so you can understand better how it works. Check your email/GitHub notifications to find the invite. If you accept it, you will also be able to clone directly our repositories, without needing to fork them. Welcome on board and once again, thank you! 🙇♀️ |
Description
Enrich global context in eval calls in
CodeEvaluator._assert_code
Motivation behind this PR?
When writing an assert statement in scanapi which uses a list (or any other) comprehension, the code would fail.
What type of change is this?
Bugfix
Checklist
Issue
Closes #512