Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change requests to httpx #557

Merged
merged 1 commit into from
May 4, 2023
Merged

feat: change requests to httpx #557

merged 1 commit into from
May 4, 2023

Conversation

taconi
Copy link
Member

@taconi taconi commented Nov 28, 2022

Description

Change requests to httpx

Motivation behind this PR?

#208

What type of change is this?

Feature

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #208

@taconi taconi requested review from a team as code owners November 28, 2022 21:40
@taconi taconi closed this Nov 28, 2022
@taconi taconi reopened this Nov 28, 2022
@taconi
Copy link
Member Author

taconi commented Nov 28, 2022

It needed to update the version of the poetry to 1.2.2 because there was an error that was corrected in this version, and the version of the python for 3.8.x because the flake8 was breaking (no further support for version 3.7)

@uesleicarvalhoo
Copy link
Contributor

@camilamaia excluding conflicts, there are some reason to don't merge this?

@camilamaia
Copy link
Member

@uesleicarvalhoo @taconi
I was checking and there are still many downloads of ScanAPI with Python 3.7:
https://pypistats.org/packages/scanapi

I also don't want to push to a breaking change "only" because of a development package. So I am not sure what would be the best way to go here...

This is the same thing that is blocking me here: #566 🤔

Ideas?

@uesleicarvalhoo
Copy link
Contributor

@camilamaia httpx is available for python 3.7 or higher, no? 🤔

@taconi taconi closed this Apr 1, 2023
@taconi taconi reopened this Apr 15, 2023
@camilamaia
Copy link
Member

@taconi I am fixing the pipelines and the dependencies. I will let you know as soon as I merge the changes :)

@taconi taconi closed this May 3, 2023
@taconi taconi reopened this May 3, 2023
@camilamaia
Copy link
Member

@taconi would you mind trying now?

@taconi
Copy link
Member Author

taconi commented May 3, 2023

It's giving an error in the demo-api, but I cloned this project and ran it locally and it's working with the definition of the files ./examples/demo-api/scanapi.yaml and ./examples/demo-api/scanapi.conf. I don't know what could be going on.

@camilamaia
Copy link
Member

We can ignore the ScanAPI Examples / Demo API check. It is a problem with GitHub actions and not the code. Sorry for the inconvenience 😢 .

The other failing check is regarding this line: https://github.com/scanapi/scanapi/pull/557/files#diff-eac99bc2fbdb913fdf03fcd5f9b3cbd3583df042256d0ab1aa42a24421c621a6R172

image

What do you think of having more specific exceptions: https://www.python-httpx.org/exceptions/?
At least for these main four HTTPError, InvalidURL, CookieConflict, StreamError.

Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taconi !!

@camilamaia camilamaia merged commit c208df5 into scanapi:main May 4, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change requests to httpx
3 participants