-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change requests to httpx #557
Conversation
It needed to update the version of the poetry to 1.2.2 because there was an error that was corrected in this version, and the version of the python for 3.8.x because the flake8 was breaking (no further support for version 3.7) |
@camilamaia excluding conflicts, there are some reason to don't merge this? |
@uesleicarvalhoo @taconi I also don't want to push to a breaking change "only" because of a development package. So I am not sure what would be the best way to go here... This is the same thing that is blocking me here: #566 🤔 Ideas? |
@camilamaia httpx is available for python 3.7 or higher, no? 🤔 |
@taconi I am fixing the pipelines and the dependencies. I will let you know as soon as I merge the changes :) |
@taconi would you mind trying now? |
It's giving an error in the demo-api, but I cloned this project and ran it locally and it's working with the definition of the files ./examples/demo-api/scanapi.yaml and ./examples/demo-api/scanapi.conf. I don't know what could be going on. |
We can ignore the The other failing check is regarding this line: https://github.com/scanapi/scanapi/pull/557/files#diff-eac99bc2fbdb913fdf03fcd5f9b3cbd3583df042256d0ab1aa42a24421c621a6R172 What do you think of having more specific exceptions: https://www.python-httpx.org/exceptions/? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @taconi !!
Description
Change requests to httpx
Motivation behind this PR?
#208
What type of change is this?
Feature
Checklist
Issue
Closes #208